Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: components/html_viewer/content_handler_impl.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/content_handler_impl.h ('k') | components/html_viewer/global_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/content_handler_impl.cc
diff --git a/components/html_viewer/content_handler_impl.cc b/components/html_viewer/content_handler_impl.cc
index 3d1a8a34790eddd75e2220a0ffb0912c68e284a4..0b3b2ef93112f36914ef9bd80d831efe31e2426b 100644
--- a/components/html_viewer/content_handler_impl.cc
+++ b/components/html_viewer/content_handler_impl.cc
@@ -12,12 +12,12 @@ namespace html_viewer {
ContentHandlerImpl::ContentHandlerImpl(
GlobalState* global_state,
- mojo::ApplicationImpl* app,
+ mojo::Shell* shell,
mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler> request)
: global_state_(global_state),
- app_(app),
+ shell_(shell),
binding_(this, std::move(request)),
- app_refcount_(app_->app_lifetime_helper()->CreateAppRefCount()) {}
+ app_refcount_(shell_->CreateAppRefCount()) {}
ContentHandlerImpl::~ContentHandlerImpl() {
}
@@ -29,7 +29,7 @@ void ContentHandlerImpl::StartApplication(
// HTMLDocumentApplicationDelegate deletes itself.
new HTMLDocumentApplicationDelegate(
std::move(request), std::move(response), global_state_,
- app_->app_lifetime_helper()->CreateAppRefCount(), destruct_callback);
+ shell_->CreateAppRefCount(), destruct_callback);
}
} // namespace html_viewer
« no previous file with comments | « components/html_viewer/content_handler_impl.h ('k') | components/html_viewer/global_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698