Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: components/html_viewer/html_viewer.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/html_viewer.h ('k') | components/html_viewer/html_widget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/html_viewer.cc
diff --git a/components/html_viewer/html_viewer.cc b/components/html_viewer/html_viewer.cc
index e133ea171488223bbe6329e5b14ef4a0d30b9025..d4750385d0790970b49e5f5c5ec5388f913003bc 100644
--- a/components/html_viewer/html_viewer.cc
+++ b/components/html_viewer/html_viewer.cc
@@ -12,15 +12,16 @@
namespace html_viewer {
-HTMLViewer::HTMLViewer() : app_(nullptr) {
+HTMLViewer::HTMLViewer() : shell_(nullptr) {
}
HTMLViewer::~HTMLViewer() {
}
-void HTMLViewer::Initialize(mojo::ApplicationImpl* app) {
- app_ = app;
- global_state_.reset(new GlobalState(app));
+void HTMLViewer::Initialize(mojo::Shell* shell, const std::string& url,
+ uint32_t id) {
+ shell_ = shell;
+ global_state_.reset(new GlobalState(shell, url));
}
bool HTMLViewer::AcceptConnection(
@@ -32,7 +33,7 @@ bool HTMLViewer::AcceptConnection(
void HTMLViewer::Create(
mojo::ApplicationConnection* connection,
mojo::InterfaceRequest<mojo::shell::mojom::ContentHandler> request) {
- new ContentHandlerImpl(global_state_.get(), app_, std::move(request));
+ new ContentHandlerImpl(global_state_.get(), shell_, std::move(request));
}
} // namespace html_viewer
« no previous file with comments | « components/html_viewer/html_viewer.h ('k') | components/html_viewer/html_widget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698