mojo/shell/runner/child/native_apptest_target.cc - Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/shell/runner/child/native_apptest_target.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/shell/runner/child/native_apptest_target.cc

diff --git a/mojo/shell/runner/child/native_apptest_target.cc b/mojo/shell/runner/child/native_apptest_target.cc

index 248685b557bb27e8fee6facf72455675111292f4..ecdbaf4971df3de942551521fa1c5f6d0681c227 100644

--- a/mojo/shell/runner/child/native_apptest_target.cc

+++ b/mojo/shell/runner/child/native_apptest_target.cc

@@ -10,8 +10,8 @@

#include "mojo/common/weak_binding_set.h"

#include "mojo/shell/public/cpp/application_connection.h"

#include "mojo/shell/public/cpp/application_delegate.h"

-#include "mojo/shell/public/cpp/application_impl.h"

#include "mojo/shell/public/cpp/interface_factory.h"

+#include "mojo/shell/public/cpp/shell.h"

#include "mojo/shell/runner/child/test_native_main.h"

#include "mojo/shell/runner/child/test_native_service.mojom.h"

#include "mojo/shell/runner/init.h"

@@ -28,7 +28,8 @@ class TargetApplicationDelegate

private:

// mojo::ApplicationDelegate:

- void Initialize(mojo::ApplicationImpl* app) override {}

+ void Initialize(mojo::Shell* shell, const std::string& url,

+ uint32_t id) override {}

bool AcceptConnection(

mojo::ApplicationConnection* connection) override {

connection->AddService<mojo::shell::test::TestNativeService>(this);

« no previous file with comments | « mojo/shell/runner/child/native_apptest.cc ('k') | mojo/shell/shell_application_delegate.h » ('j') | no next file with comments »