Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: media/mojo/services/mojo_media_application.h

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/mojo/services/media_apptest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "media/mojo/interfaces/service_factory.mojom.h" 6 #include "media/mojo/interfaces/service_factory.mojom.h"
7 #include "mojo/shell/public/cpp/application_delegate.h" 7 #include "mojo/shell/public/cpp/application_delegate.h"
8 #include "mojo/shell/public/cpp/interface_factory_impl.h" 8 #include "mojo/shell/public/cpp/interface_factory_impl.h"
9 #include "url/gurl.h" 9 #include "url/gurl.h"
10 10
11 namespace media { 11 namespace media {
12 12
13 class MediaLog; 13 class MediaLog;
14 class MojoMediaClient; 14 class MojoMediaClient;
15 15
16 class MojoMediaApplication 16 class MojoMediaApplication
17 : public mojo::ApplicationDelegate, 17 : public mojo::ApplicationDelegate,
18 public mojo::InterfaceFactory<interfaces::ServiceFactory> { 18 public mojo::InterfaceFactory<interfaces::ServiceFactory> {
19 public: 19 public:
20 static scoped_ptr<mojo::ApplicationDelegate> CreateApp(); 20 static scoped_ptr<mojo::ApplicationDelegate> CreateApp();
21 21
22 explicit MojoMediaApplication(scoped_ptr<MojoMediaClient> mojo_media_client); 22 explicit MojoMediaApplication(scoped_ptr<MojoMediaClient> mojo_media_client);
23 ~MojoMediaApplication() final; 23 ~MojoMediaApplication() final;
24 24
25 private: 25 private:
26 // mojo::ApplicationDelegate implementation. 26 // mojo::ApplicationDelegate implementation.
27 void Initialize(mojo::ApplicationImpl* app) final; 27 void Initialize(mojo::Shell* shell,
28 const std::string& url,
29 uint32_t id) final;
28 bool AcceptConnection(mojo::ApplicationConnection* connection) final; 30 bool AcceptConnection(mojo::ApplicationConnection* connection) final;
29 31
30 // mojo::InterfaceFactory<interfaces::ServiceFactory> implementation. 32 // mojo::InterfaceFactory<interfaces::ServiceFactory> implementation.
31 void Create(mojo::ApplicationConnection* connection, 33 void Create(mojo::ApplicationConnection* connection,
32 mojo::InterfaceRequest<interfaces::ServiceFactory> request) final; 34 mojo::InterfaceRequest<interfaces::ServiceFactory> request) final;
33 35
34 scoped_ptr<MojoMediaClient> mojo_media_client_; 36 scoped_ptr<MojoMediaClient> mojo_media_client_;
35 mojo::ApplicationImpl* app_impl_; 37 mojo::Shell* shell_;
36 scoped_refptr<MediaLog> media_log_; 38 scoped_refptr<MediaLog> media_log_;
37 }; 39 };
38 40
39 } // namespace media 41 } // namespace media
OLDNEW
« no previous file with comments | « media/mojo/services/media_apptest.cc ('k') | media/mojo/services/mojo_media_application.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698