Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: mojo/services/test_service/test_request_tracker_application.cc

Issue 1674903003: Extract shell methods from ApplicationImpl into a base class, and pass this to Initialize() instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojom
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/test_service/test_request_tracker_application.cc
diff --git a/mojo/services/test_service/test_request_tracker_application.cc b/mojo/services/test_service/test_request_tracker_application.cc
index b9179d27719cd85502f0f08319c90482a528d744..cf5d83187707bedcdb4abe6446b6ee4ba14bace8 100644
--- a/mojo/services/test_service/test_request_tracker_application.cc
+++ b/mojo/services/test_service/test_request_tracker_application.cc
@@ -16,14 +16,13 @@ namespace mojo {
namespace test {
TestRequestTrackerApplication::TestRequestTrackerApplication()
- : app_impl_(nullptr) {
-}
-
-TestRequestTrackerApplication::~TestRequestTrackerApplication() {
-}
+ : shell_(nullptr) {}
+TestRequestTrackerApplication::~TestRequestTrackerApplication() {}
-void TestRequestTrackerApplication::Initialize(ApplicationImpl* app) {
- app_impl_ = app;
+void TestRequestTrackerApplication::Initialize(Shell* shell,
+ const std::string& url,
+ uint32_t id) {
+ shell_ = shell;
}
bool TestRequestTrackerApplication::AcceptConnection(
@@ -39,7 +38,7 @@ bool TestRequestTrackerApplication::AcceptConnection(
void TestRequestTrackerApplication::Create(
ApplicationConnection* connection,
InterfaceRequest<TestTimeService> request) {
- new TestTimeServiceImpl(app_impl_, std::move(request));
+ new TestTimeServiceImpl(shell_, std::move(request));
}
void TestRequestTrackerApplication::Create(
« no previous file with comments | « mojo/services/test_service/test_request_tracker_application.h ('k') | mojo/services/test_service/test_service_application.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698