Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

BUG=554298
Committed: https://crrev.com/c963c714c99f34bd80b392d9896ca9cecd66fb6d
Cr-Commit-Position: refs/heads/master@{#385980}

[dcheng, 2016-04-07 20:10:08]

dcheng@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[dcheng, 2016-04-07 20:10:12]

This is largely a search and replace. There's probably some IWYU errors (files
that don't include memory when they should and those that do when they
shouldn't), but fixing those is out-of-scope for this conversion work.

[Devlin, 2016-04-07 20:42:11]

On 2016/04/07 20:10:12, dcheng wrote:
> This is largely a search and replace. There's probably some IWYU errors (files
> that don't include memory when they should and those that do when they
> shouldn't), but fixing those is out-of-scope for this conversion work.

Looks like there are a few compile failures - mind re-pinging when green?

[dcheng, 2016-04-07 20:46:49]

On 2016/04/07 at 20:42:11, rdevlin.cronin wrote:
> On 2016/04/07 20:10:12, dcheng wrote:
> > This is largely a search and replace. There's probably some IWYU errors
(files
> > that don't include memory when they should and those that do when they
> > shouldn't), but fixing those is out-of-scope for this conversion work.
> 
> Looks like there are a few compile failures - mind re-pinging when green?

It looks like this is mostly blocked on IWYU failures in chromeos.  I expect
these to be fixed once I land the CrOS patch
(https://codereview.chromium.org/1870793002, which is also currently not
compiling, due to IWYU fails in content/public)

[Devlin, 2016-04-07 21:32:29]

contender for biggest patch I've reviewed.

LGTM.

https://codereview.chromium.org/1871713002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc
(right):

https://codereview.chromium.org/1871713002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc:5:
#include
"chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h"
What's going on with these includes?  I think braille_controller.h was a
right-er choice for a parent.

[dcheng, 2016-04-07 21:42:22]

https://codereview.chromium.org/1871713002/diff/1/chrome/browser/extensions/a...
File
chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc
(right):

https://codereview.chromium.org/1871713002/diff/1/chrome/browser/extensions/a...
chrome/browser/extensions/api/braille_display_private/braille_controller_stub.cc:5:
#include
"chrome/browser/extensions/api/braille_display_private/stub_braille_controller.h"
On 2016/04/07 at 21:32:28, Devlin wrote:
> What's going on with these includes?  I think braille_controller.h was a
right-er choice for a parent.

Oops, I manually undid this and mixed it up. I'll fix it after the chromeos bits
land.

[dcheng, 2016-04-08 02:58:07]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-08 02:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/1871713002/#ps10001
(title: "Rebase and fix header")

[commit-bot: I haz the power, 2016-04-08 02:59:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1871713002/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1871713002/10001

[commit-bot: I haz the power, 2016-04-08 03:55:47]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2016-04-08 03:56:49]

Description was changed from

==========
Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

BUG=554298
==========

to

==========
Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

BUG=554298

Committed: https://crrev.com/c963c714c99f34bd80b392d9896ca9cecd66fb6d
Cr-Commit-Position: refs/heads/master@{#385980}
==========

[commit-bot: I haz the power, 2016-04-08 03:56:52]

Patchset 2 (id:??) landed as
https://crrev.com/c963c714c99f34bd80b392d9896ca9cecd66fb6d
Cr-Commit-Position: refs/heads/master@{#385980}