Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3847)

Unified Diff: chrome/browser/extensions/api/log_private/log_private_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/log_private/log_private_api.h
diff --git a/chrome/browser/extensions/api/log_private/log_private_api.h b/chrome/browser/extensions/api/log_private/log_private_api.h
index d54ef6122b616d987aaea751f670870be1d51cfe..4ea5c34936e0e345aafa446dd7a7566b92f976b9 100644
--- a/chrome/browser/extensions/api/log_private/log_private_api.h
+++ b/chrome/browser/extensions/api/log_private/log_private_api.h
@@ -88,7 +88,7 @@ class LogPrivateAPI : public BrowserContextKeyedAPI,
void OnAddEntry(const net::NetLog::Entry& entry) override;
void PostPendingEntries();
- void AddEntriesOnUI(scoped_ptr<base::ListValue> value);
+ void AddEntriesOnUI(std::unique_ptr<base::ListValue> value);
// Creates a file that will be written to by net::WriteToFileNetLogObserver.
void CreateTempNetLogFile(const std::string& owner_extension_id,
@@ -113,8 +113,8 @@ class LogPrivateAPI : public BrowserContextKeyedAPI,
bool logging_net_internals_;
api::log_private::EventSink event_sink_;
std::set<std::string> net_internal_watches_;
- scoped_ptr<base::ListValue> pending_entries_;
- scoped_ptr<net::WriteToFileNetLogObserver> write_to_file_observer_;
+ std::unique_ptr<base::ListValue> pending_entries_;
+ std::unique_ptr<net::WriteToFileNetLogObserver> write_to_file_observer_;
// Listen to extension unloaded notifications.
ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
extension_registry_observer_;
@@ -136,9 +136,10 @@ class LogPrivateGetHistoricalFunction : public AsyncExtensionFunction {
bool RunAsync() override;
private:
- void OnSystemLogsLoaded(scoped_ptr<system_logs::SystemLogsResponse> sys_info);
+ void OnSystemLogsLoaded(
+ std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
- scoped_ptr<FilterHandler> filter_handler_;
+ std::unique_ptr<FilterHandler> filter_handler_;
DISALLOW_COPY_AND_ASSIGN(LogPrivateGetHistoricalFunction);
};

Powered by Google App Engine
This is Rietveld 408576698