Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: chrome/browser/extensions/permissions_updater.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/permissions_updater.cc
diff --git a/chrome/browser/extensions/permissions_updater.cc b/chrome/browser/extensions/permissions_updater.cc
index b1917312428ee655d995828df7d515e49790bb10..4370e3214939ed9d3565d61660a7015d0721bd6e 100644
--- a/chrome/browser/extensions/permissions_updater.cc
+++ b/chrome/browser/extensions/permissions_updater.cc
@@ -36,7 +36,7 @@ namespace {
// Returns a PermissionSet that has the active permissions of the extension,
// bounded to its current manifest.
-scoped_ptr<const PermissionSet> GetBoundedActivePermissions(
+std::unique_ptr<const PermissionSet> GetBoundedActivePermissions(
const Extension* extension,
const PermissionSet* active_permissions) {
// If the extension has used the optional permissions API, it will have a
@@ -52,13 +52,13 @@ scoped_ptr<const PermissionSet> GetBoundedActivePermissions(
// extension's manifest.
// a) active permissions must be a subset of optional + default permissions
// b) active permissions must contains all default permissions
- scoped_ptr<const PermissionSet> total_permissions =
+ std::unique_ptr<const PermissionSet> total_permissions =
PermissionSet::CreateUnion(
required_permissions,
PermissionsParser::GetOptionalPermissions(extension));
// Make sure the active permissions contain no more than optional + default.
- scoped_ptr<const PermissionSet> adjusted_active =
+ std::unique_ptr<const PermissionSet> adjusted_active =
PermissionSet::CreateIntersection(*total_permissions,
*active_permissions);
@@ -86,12 +86,12 @@ void PermissionsUpdater::AddPermissions(const Extension* extension,
const PermissionSet& permissions) {
const PermissionSet& active =
extension->permissions_data()->active_permissions();
- scoped_ptr<const PermissionSet> total =
+ std::unique_ptr<const PermissionSet> total =
PermissionSet::CreateUnion(active, permissions);
- scoped_ptr<const PermissionSet> added =
+ std::unique_ptr<const PermissionSet> added =
PermissionSet::CreateDifference(*total, active);
- scoped_ptr<const PermissionSet> new_withheld =
+ std::unique_ptr<const PermissionSet> new_withheld =
PermissionSet::CreateDifference(
extension->permissions_data()->withheld_permissions(), permissions);
SetPermissions(extension, std::move(total), std::move(new_withheld));
@@ -110,17 +110,17 @@ void PermissionsUpdater::RemovePermissions(const Extension* extension,
const PermissionSet& active =
extension->permissions_data()->active_permissions();
- scoped_ptr<const PermissionSet> remaining =
+ std::unique_ptr<const PermissionSet> remaining =
PermissionSet::CreateDifference(active, to_remove);
// Move any granted permissions that were in the withheld set back to the
// withheld set so they can be added back later.
// Any revoked permission that isn't from the optional permissions can only
// be a withheld permission.
- scoped_ptr<const PermissionSet> removed_withheld =
+ std::unique_ptr<const PermissionSet> removed_withheld =
PermissionSet::CreateDifference(
to_remove, PermissionsParser::GetOptionalPermissions(extension));
- scoped_ptr<const PermissionSet> withheld = PermissionSet::CreateUnion(
+ std::unique_ptr<const PermissionSet> withheld = PermissionSet::CreateUnion(
*removed_withheld, extension->permissions_data()->withheld_permissions());
SetPermissions(extension, std::move(remaining), std::move(withheld));
@@ -141,25 +141,25 @@ void PermissionsUpdater::RemovePermissionsUnsafe(
const PermissionSet& to_remove) {
const PermissionSet& active =
extension->permissions_data()->active_permissions();
- scoped_ptr<const PermissionSet> total =
+ std::unique_ptr<const PermissionSet> total =
PermissionSet::CreateDifference(active, to_remove);
// |successfully_removed| might not equal |to_remove| if |to_remove| contains
// permissions the extension didn't have.
- scoped_ptr<const PermissionSet> successfully_removed =
+ std::unique_ptr<const PermissionSet> successfully_removed =
PermissionSet::CreateDifference(active, *total);
SetPermissions(extension, std::move(total), nullptr);
NotifyPermissionsUpdated(REMOVED, extension, *successfully_removed);
}
-scoped_ptr<const PermissionSet> PermissionsUpdater::GetRevokablePermissions(
- const Extension* extension) const {
+std::unique_ptr<const PermissionSet>
+PermissionsUpdater::GetRevokablePermissions(const Extension* extension) const {
// The user can revoke any permissions they granted. In other words, any
// permissions the extension didn't start with can be revoked.
const PermissionSet& required =
PermissionsParser::GetRequiredPermissions(extension);
- scoped_ptr<const PermissionSet> granted;
- scoped_ptr<const PermissionSet> withheld;
+ std::unique_ptr<const PermissionSet> granted;
+ std::unique_ptr<const PermissionSet> withheld;
ScriptingPermissionsModifier(browser_context_, make_scoped_refptr(extension))
.WithholdPermissions(required, &granted, &withheld, true);
return PermissionSet::CreateDifference(
@@ -175,14 +175,14 @@ void PermissionsUpdater::GrantActivePermissions(const Extension* extension) {
}
void PermissionsUpdater::InitializePermissions(const Extension* extension) {
- scoped_ptr<const PermissionSet> bounded_wrapper;
+ std::unique_ptr<const PermissionSet> bounded_wrapper;
const PermissionSet* bounded_active = nullptr;
// If |extension| is a transient dummy extension, we do not want to look for
// it in preferences.
if (init_flag_ & INIT_FLAG_TRANSIENT) {
bounded_active = &extension->permissions_data()->active_permissions();
} else {
- scoped_ptr<const PermissionSet> active_permissions =
+ std::unique_ptr<const PermissionSet> active_permissions =
ExtensionPrefs::Get(browser_context_)
->GetActivePermissions(extension->id());
bounded_wrapper =
@@ -190,8 +190,8 @@ void PermissionsUpdater::InitializePermissions(const Extension* extension) {
bounded_active = bounded_wrapper.get();
}
- scoped_ptr<const PermissionSet> granted_permissions;
- scoped_ptr<const PermissionSet> withheld_permissions;
+ std::unique_ptr<const PermissionSet> granted_permissions;
+ std::unique_ptr<const PermissionSet> withheld_permissions;
ScriptingPermissionsModifier(browser_context_, make_scoped_refptr(extension))
.WithholdPermissions(*bounded_active, &granted_permissions,
&withheld_permissions,
@@ -203,8 +203,8 @@ void PermissionsUpdater::InitializePermissions(const Extension* extension) {
void PermissionsUpdater::SetPermissions(
const Extension* extension,
- scoped_ptr<const PermissionSet> active,
- scoped_ptr<const PermissionSet> withheld) {
+ std::unique_ptr<const PermissionSet> active,
+ std::unique_ptr<const PermissionSet> withheld) {
DCHECK(active);
const PermissionSet& active_weak = *active;
if (withheld) {
@@ -229,11 +229,11 @@ void PermissionsUpdater::DispatchEvent(
if (!event_router)
return;
- scoped_ptr<base::ListValue> value(new base::ListValue());
- scoped_ptr<api::permissions::Permissions> permissions =
+ std::unique_ptr<base::ListValue> value(new base::ListValue());
+ std::unique_ptr<api::permissions::Permissions> permissions =
PackPermissionSet(changed_permissions);
value->Append(permissions->ToValue().release());
- scoped_ptr<Event> event(
+ std::unique_ptr<Event> event(
new Event(histogram_value, event_name, std::move(value)));
event->restrict_to_browser_context = browser_context_;
event_router->DispatchEventToExtension(extension_id, std::move(event));
« no previous file with comments | « chrome/browser/extensions/permissions_updater.h ('k') | chrome/browser/extensions/permissions_updater_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698