chrome/browser/extensions/unpacked_installer.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/unpacked_installer.h ('k') | chrome/browser/extensions/updater/chrome_extension_downloader_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index bc28a4d2eba3dab917d01f3c2d61a5b9dc63cac0..f812a2f5f368e2391f6404ffb8128699c844337f 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -59,7 +59,7 @@ class SimpleExtensionLoadPrompt {

void OnInstallPromptDone(ExtensionInstallPrompt::Result result);

- scoped_ptr<ExtensionInstallPrompt> install_ui_;

+ std::unique_ptr<ExtensionInstallPrompt> install_ui_;

scoped_refptr<const Extension> extension_;

base::Closure callback_;

@@ -71,7 +71,7 @@ SimpleExtensionLoadPrompt::SimpleExtensionLoadPrompt(

Profile* profile,

const base::Closure& callback)

: extension_(extension), callback_(callback) {

- scoped_ptr<extensions::ExtensionInstallUI> ui(

+ std::unique_ptr<extensions::ExtensionInstallUI> ui(

extensions::CreateExtensionInstallUI(profile));

install_ui_.reset(new ExtensionInstallPrompt(

profile, ui->GetDefaultInstallDialogParent()));