chrome/browser/extensions/extension_browsertest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_browsertest.h ('k') | chrome/browser/extensions/extension_context_menu_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index 34765741feaf56c1e78b7d9c5256c608030e8b19..0758fbcaa5c0f6a66b84cd6630aa901b2ccd0e8c 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -365,7 +365,7 @@ base::FilePath ExtensionBrowserTest::PackExtensionWithOptions(

return base::FilePath();

}

- scoped_ptr<ExtensionCreator> creator(new ExtensionCreator());

+ std::unique_ptr<ExtensionCreator> creator(new ExtensionCreator());

if (!creator->Run(dir_path,

crx_path,

pem_path,

@@ -469,7 +469,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(

size_t num_before = registry->enabled_extensions().size();

{

- scoped_ptr<ScopedTestDialogAutoConfirm> prompt_auto_confirm;

+ std::unique_ptr<ScopedTestDialogAutoConfirm> prompt_auto_confirm;

if (ui_type == INSTALL_UI_TYPE_CANCEL) {

prompt_auto_confirm.reset(new ScopedTestDialogAutoConfirm(

ScopedTestDialogAutoConfirm::CANCEL));

@@ -490,7 +490,7 @@ const Extension* ExtensionBrowserTest::InstallOrUpdateExtension(

if (crx_path.empty())

return NULL;

- scoped_ptr<ExtensionInstallPrompt> install_ui;

+ std::unique_ptr<ExtensionInstallPrompt> install_ui;

if (prompt_auto_confirm) {

install_ui.reset(new ExtensionInstallPrompt(

browser->tab_strip_model()->GetActiveWebContents()));