chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api_unittest.cc ('k') | chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

diff --git a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

index 786d1ec98fe2d1fcb6ae4a552adfba7c538f1c4c..ecb7a823c536efca92c2d6b84f72715e577ec5fc 100644

--- a/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

+++ b/chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc

@@ -4,13 +4,13 @@

#include "chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.h"

+#include <memory>

#include <string>

#include <utility>

#include <vector>

#include "base/lazy_instance.h"

#include "base/memory/linked_ptr.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/scoped_vector.h"

#include "base/values.h"

#include "chrome/browser/extensions/api/signed_in_devices/signed_in_devices_api.h"

@@ -72,9 +72,9 @@ void SignedInDevicesChangeObserver::OnDeviceInfoChange() {

args.push_back(std::move(api_device));

}

- scoped_ptr<base::ListValue> result =

+ std::unique_ptr<base::ListValue> result =

api::signed_in_devices::OnDeviceInfoChange::Create(args);

- scoped_ptr<Event> event(

+ std::unique_ptr<Event> event(

new Event(events::SIGNED_IN_DEVICES_ON_DEVICE_INFO_CHANGE,

api::signed_in_devices::OnDeviceInfoChange::kEventName,

std::move(result)));