chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/write_from_url_operation.h ('k') | chrome/browser/extensions/api/inline_install_private/inline_install_private_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

index f539ce4c945358519786b7cdf211bdb35ea0ae54..afb463905a203b9eced40f9eab18872c3f8eb98e 100644

--- a/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

+++ b/chrome/browser/extensions/api/image_writer_private/write_from_url_operation_unittest.cc

@@ -102,7 +102,7 @@ class ImageWriterWriteFromUrlOperationTest : public ImageWriterUnitTestBase {

}

TestingProfile test_profile_;

- scoped_ptr<GetInterceptor> get_interceptor_;

+ std::unique_ptr<GetInterceptor> get_interceptor_;

MockOperationManager manager_;

};

@@ -174,7 +174,7 @@ TEST_F(ImageWriterWriteFromUrlOperationTest, DownloadFile) {

}

TEST_F(ImageWriterWriteFromUrlOperationTest, VerifyFile) {

- scoped_ptr<char[]> data_buffer(new char[kTestFileSize]);

+ std::unique_ptr<char[]> data_buffer(new char[kTestFileSize]);

base::ReadFile(test_utils_.GetImagePath(), data_buffer.get(), kTestFileSize);

base::MD5Digest expected_digest;

base::MD5Sum(data_buffer.get(), kTestFileSize, &expected_digest);