chrome/browser/extensions/api/chrome_extensions_api_client.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc ('k') | chrome/browser/extensions/api/chrome_extensions_api_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/chrome_extensions_api_client.h

diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.h b/chrome/browser/extensions/api/chrome_extensions_api_client.h

index 43337306540ee5b31a11b3d37bd8b233efb63d00..cfa11b39979a22901da2fec462fd677360830503 100644

--- a/chrome/browser/extensions/api/chrome_extensions_api_client.h

+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.h

@@ -30,10 +30,11 @@ class ChromeExtensionsAPIClient : public ExtensionsAPIClient {

AppViewGuestDelegate* CreateAppViewGuestDelegate() const override;

ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate(

ExtensionOptionsGuest* guest) const override;

- scoped_ptr<guest_view::GuestViewManagerDelegate>

- CreateGuestViewManagerDelegate(

- content::BrowserContext* context) const override;

- scoped_ptr<MimeHandlerViewGuestDelegate> CreateMimeHandlerViewGuestDelegate(

+ std::unique_ptr<guest_view::GuestViewManagerDelegate>

+ CreateGuestViewManagerDelegate(

+ content::BrowserContext* context) const override;

+ std::unique_ptr<MimeHandlerViewGuestDelegate>

+ CreateMimeHandlerViewGuestDelegate(

MimeHandlerViewGuest* guest) const override;

WebViewGuestDelegate* CreateWebViewGuestDelegate(

WebViewGuest* web_view_guest) const override;

@@ -44,9 +45,9 @@ class ChromeExtensionsAPIClient : public ExtensionsAPIClient {

scoped_refptr<ContentRulesRegistry> CreateContentRulesRegistry(

content::BrowserContext* browser_context,

RulesCacheDelegate* cache_delegate) const override;

- scoped_ptr<DevicePermissionsPrompt> CreateDevicePermissionsPrompt(

+ std::unique_ptr<DevicePermissionsPrompt> CreateDevicePermissionsPrompt(

content::WebContents* web_contents) const override;

- scoped_ptr<VirtualKeyboardDelegate> CreateVirtualKeyboardDelegate()

+ std::unique_ptr<VirtualKeyboardDelegate> CreateVirtualKeyboardDelegate()

const override;

ManagementAPIDelegate* CreateManagementAPIDelegate() const override;