chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/chrome_extensions_api_client.cc ('k') | chrome/browser/extensions/api/command_line_private/command_line_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

index 0de30f6f956d4d5740ae8ba92cfeaeb47765730d..2f590068b522982da0c1e9ebfe0a242cc3bfe831 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

@@ -40,7 +40,7 @@ CloudPrintPrivateSetupConnectorFunction::

bool CloudPrintPrivateSetupConnectorFunction::RunAsync() {

#if defined(ENABLE_PRINT_PREVIEW)

using api::cloud_print_private::SetupConnector::Params;

- scoped_ptr<Params> params(Params::Create(*args_));

+ std::unique_ptr<Params> params(Params::Create(*args_));

if (CloudPrintTestsDelegate::instance()) {

CloudPrintTestsDelegate::instance()->SetupConnector(

params->user_email,

@@ -52,7 +52,7 @@ bool CloudPrintPrivateSetupConnectorFunction::RunAsync() {

CloudPrintProxyServiceFactory::GetForProfile(GetProfile());

if (!service)

return false;

- scoped_ptr<base::DictionaryValue> user_setings(

+ std::unique_ptr<base::DictionaryValue> user_setings(

params->user_settings.ToValue());

service->EnableForUserWithRobot(params->credentials,

params->robot_email,