chrome/browser/extensions/extension_action_manager.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_manager.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_icon_factory_unittest.cc ('k') | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_manager.h

diff --git a/chrome/browser/extensions/extension_action_manager.h b/chrome/browser/extensions/extension_action_manager.h

index 53451d593d7752f27523cbc14bd4744c5c7562b9..3e6569687430435edc373b1eebeb4f3173f5a3b7 100644

--- a/chrome/browser/extensions/extension_action_manager.h

+++ b/chrome/browser/extensions/extension_action_manager.h

@@ -51,8 +51,9 @@ class ExtensionActionManager : public KeyedService,

// Gets the best fit ExtensionAction for the given |extension|. This takes

// into account |extension|'s browser or page actions, if any, along with its

// name and any declared icons.

- scoped_ptr<ExtensionAction> GetBestFitAction(

- const Extension& extension, ActionInfo::Type type) const;

+ std::unique_ptr<ExtensionAction> GetBestFitAction(

+ const Extension& extension,

+ ActionInfo::Type type) const;

private:

// Implement ExtensionRegistryObserver.