chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc ('k') | chrome/browser/extensions/api/messaging/native_messaging_policy_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

index bb498455775147f944d863e1ac2362d5c3fb9b6f..1600a20ee98bd3f87e79cff75cc401cf3fe0608e 100644

--- a/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc

@@ -74,7 +74,7 @@ TEST_F(NativeMessagingHostManifestTest, LoadValid) {

ASSERT_TRUE(WriteManifest(kTestHostName, kTestHostPath, kTestOrigin));

std::string error_message;

- scoped_ptr<NativeMessagingHostManifest> manifest =

+ std::unique_ptr<NativeMessagingHostManifest> manifest =

NativeMessagingHostManifest::Load(manifest_path_, &error_message);

ASSERT_TRUE(manifest) << "Failed to load manifest: " << error_message;

EXPECT_TRUE(error_message.empty());

@@ -95,7 +95,7 @@ TEST_F(NativeMessagingHostManifestTest, InvalidName) {

kTestHostPath, kTestOrigin));

std::string error_message;

- scoped_ptr<NativeMessagingHostManifest> manifest =

+ std::unique_ptr<NativeMessagingHostManifest> manifest =

NativeMessagingHostManifest::Load(manifest_path_, &error_message);

ASSERT_FALSE(manifest);

EXPECT_FALSE(error_message.empty());

@@ -107,7 +107,7 @@ TEST_F(NativeMessagingHostManifestTest, MatchAllOrigin) {

"chrome-extension://*/"));

std::string error_message;

- scoped_ptr<NativeMessagingHostManifest> manifest =

+ std::unique_ptr<NativeMessagingHostManifest> manifest =

NativeMessagingHostManifest::Load(manifest_path_, &error_message);

ASSERT_FALSE(manifest);

EXPECT_FALSE(error_message.empty());