chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/brlapi_connection.h ('k') | chrome/browser/extensions/api/braille_display_private/brlapi_keycode_map.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc b/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc

index c2531cd01b219abce94b32fd8f46ba048d3928fe..5739710383dceb519f03c0051fd71f11a875efd0 100644

--- a/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc

+++ b/chrome/browser/extensions/api/braille_display_private/brlapi_connection.cc

@@ -57,7 +57,7 @@ class BrlapiConnectionImpl : public BrlapiConnection,

ConnectResult ConnectResultForError();

LibBrlapiLoader* libbrlapi_loader_;

- scoped_ptr<brlapi_handle_t, base::FreeDeleter> handle_;

+ std::unique_ptr<brlapi_handle_t, base::FreeDeleter> handle_;

MessageLoopForIO::FileDescriptorWatcher fd_controller_;

OnDataReadyCallback on_data_ready_;

@@ -70,10 +70,10 @@ BrlapiConnection::BrlapiConnection() {

BrlapiConnection::~BrlapiConnection() {

}

-scoped_ptr<BrlapiConnection> BrlapiConnection::Create(

+std::unique_ptr<BrlapiConnection> BrlapiConnection::Create(

LibBrlapiLoader* loader) {

DCHECK(loader->loaded());

- return scoped_ptr<BrlapiConnection>(new BrlapiConnectionImpl(loader));

+ return std::unique_ptr<BrlapiConnection>(new BrlapiConnectionImpl(loader));

}

BrlapiConnection::ConnectResult BrlapiConnectionImpl::Connect(