chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/passwords_private/passwords_private_event_router.h ('k') | chrome/browser/extensions/api/permissions/permissions_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

index a8c0952668a84a306d01de00cc1202f1fbd2c68c..e9fb4d517d2dc678c20bdd28708552f5c625ebd2 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_event_router.cc

@@ -90,7 +90,7 @@ void PasswordsPrivateEventRouter::SendSavedPasswordListToListeners() {

// If there is nothing to send, return early.

return;

- scoped_ptr<Event> extension_event(

+ std::unique_ptr<Event> extension_event(

new Event(events::PASSWORDS_PRIVATE_ON_SAVED_PASSWORDS_LIST_CHANGED,

api::passwords_private::OnSavedPasswordsListChanged::kEventName,

cached_saved_password_parameters_->CreateDeepCopy()));

@@ -110,7 +110,7 @@ void PasswordsPrivateEventRouter::SendPasswordExceptionListToListeners() {

// If there is nothing to send, return early.

return;

- scoped_ptr<Event> extension_event(new Event(

+ std::unique_ptr<Event> extension_event(new Event(

events::PASSWORDS_PRIVATE_ON_PASSWORD_EXCEPTIONS_LIST_CHANGED,

api::passwords_private::OnPasswordExceptionsListChanged::kEventName,

cached_password_exception_parameters_->CreateDeepCopy()));

@@ -126,10 +126,10 @@ void PasswordsPrivateEventRouter::OnPlaintextPasswordFetched(

params.login_pair.username = username;

params.plaintext_password = plaintext_password;

- scoped_ptr<base::ListValue> event_value(new base::ListValue);

+ std::unique_ptr<base::ListValue> event_value(new base::ListValue);

event_value->Append(params.ToValue());

- scoped_ptr<Event> extension_event(new Event(

+ std::unique_ptr<Event> extension_event(new Event(

events::PASSWORDS_PRIVATE_ON_PLAINTEXT_PASSWORD_RETRIEVED,

api::passwords_private::OnPlaintextPasswordRetrieved::kEventName,

std::move(event_value)));