chrome/browser/extensions/api/developer_private/extension_info_generator.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/extension_info_generator.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_mangle.cc ('k') | chrome/browser/extensions/api/developer_private/extension_info_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/extension_info_generator.h

diff --git a/chrome/browser/extensions/api/developer_private/extension_info_generator.h b/chrome/browser/extensions/api/developer_private/extension_info_generator.h

index 5a47e842ac557dce1be28a6ec9bbb4454957d939..54f770b53614889cdaafebaaf1f114db8dc3ac2a 100644

--- a/chrome/browser/extensions/api/developer_private/extension_info_generator.h

+++ b/chrome/browser/extensions/api/developer_private/extension_info_generator.h

@@ -61,8 +61,9 @@ class ExtensionInfoGenerator {

api::developer_private::ExtensionState state);

// Callback for the asynchronous image loading.

- void OnImageLoaded(scoped_ptr<api::developer_private::ExtensionInfo> info,

- const gfx::Image& image);

+ void OnImageLoaded(

+ std::unique_ptr<api::developer_private::ExtensionInfo> info,

+ const gfx::Image& image);

// Returns the icon url for the default icon to use.

const std::string& GetDefaultIconUrl(bool is_app, bool is_disabled);