Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fix header Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
diff --git a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
index 9cae7a2d720453d53b322b185b5408772405a363..118174890c9f4cc085a918216eaed3d1b891710d 100644
--- a/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
+++ b/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
@@ -9,6 +9,7 @@
#include "base/bind_helpers.h"
#include "base/command_line.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
@@ -46,9 +47,9 @@ const char kId1[] = "iccfkkhkfiphcjdakkmcjmkfboccmndk";
const char kId2[] = "ajjhifimiemdpmophmkkkcijegphclbl";
const char kId3[] = "ioibbbfddncmmabjmpokikkeiofalaek";
-scoped_ptr<KeyedService> BuildOverrideRegistrar(
+std::unique_ptr<KeyedService> BuildOverrideRegistrar(
content::BrowserContext* context) {
- return make_scoped_ptr(
+ return base::WrapUnique(
new extensions::ExtensionWebUIOverrideRegistrar(context));
}
@@ -330,7 +331,7 @@ class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {
Manifest::Location location,
const std::string& data,
const std::string& id) {
- scoped_ptr<base::DictionaryValue> parsed_manifest(
+ std::unique_ptr<base::DictionaryValue> parsed_manifest(
api_test_utils::ParseDictionary(data));
return api_test_utils::CreateExtension(location, parsed_manifest.get(), id);
}
@@ -338,7 +339,7 @@ class ExtensionMessageBubbleTest : public BrowserWithTestWindowTest {
ExtensionService* service_;
private:
- scoped_ptr<base::CommandLine> command_line_;
+ std::unique_ptr<base::CommandLine> command_line_;
DISALLOW_COPY_AND_ASSIGN(ExtensionMessageBubbleTest);
};
@@ -348,7 +349,7 @@ TEST_F(ExtensionMessageBubbleTest, BubbleReshowsOnDeactivationDismissal) {
ASSERT_TRUE(LoadExtensionOverridingNtp("1", kId1, Manifest::INTERNAL));
ASSERT_TRUE(LoadExtensionOverridingNtp("2", kId2, Manifest::INTERNAL));
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
new NtpOverriddenBubbleDelegate(browser()->profile()), browser()));
@@ -417,7 +418,7 @@ TEST_F(ExtensionMessageBubbleTest, WipeoutControllerTest) {
ASSERT_TRUE(LoadGenericExtension("2", kId2, Manifest::UNPACKED));
ASSERT_TRUE(LoadGenericExtension("3", kId3, Manifest::EXTERNAL_POLICY));
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
new SuspiciousExtensionBubbleDelegate(browser()->profile()),
browser()));
@@ -496,10 +497,9 @@ TEST_F(ExtensionMessageBubbleTest, DevModeControllerTest) {
ASSERT_TRUE(LoadGenericExtension("2", kId2, Manifest::UNPACKED));
ASSERT_TRUE(LoadGenericExtension("3", kId3, Manifest::EXTERNAL_POLICY));
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
- new DevModeBubbleDelegate(browser()->profile()),
- browser()));
+ new DevModeBubbleDelegate(browser()->profile()), browser()));
// The list will contain one enabled unpacked extension.
EXPECT_TRUE(controller->ShouldShow());
@@ -630,7 +630,7 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_SettingsApiControllerTest) {
}
SettingsApiOverrideType type = static_cast<SettingsApiOverrideType>(i);
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
new SettingsApiBubbleDelegate(browser()->profile(), type),
browser()));
@@ -741,10 +741,9 @@ TEST_F(ExtensionMessageBubbleTest, NtpOverriddenControllerTest) {
ASSERT_TRUE(LoadExtensionOverridingNtp("2", kId2, Manifest::UNPACKED));
ASSERT_TRUE(LoadExtensionOverridingStart("3", kId3, Manifest::UNPACKED));
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
- new NtpOverriddenBubbleDelegate(browser()->profile()),
- browser()));
+ new NtpOverriddenBubbleDelegate(browser()->profile()), browser()));
// The list will contain one enabled unpacked extension (ext 2).
EXPECT_TRUE(controller->ShouldShow());
@@ -877,10 +876,9 @@ TEST_F(ExtensionMessageBubbleTest, MAYBE_ProxyOverriddenControllerTest) {
SetInstallTime(kId2, base::Time::Now(), prefs);
SetInstallTime(kId3, old_enough, prefs);
- scoped_ptr<TestExtensionMessageBubbleController> controller(
+ std::unique_ptr<TestExtensionMessageBubbleController> controller(
new TestExtensionMessageBubbleController(
- new ProxyOverriddenBubbleDelegate(browser()->profile()),
- browser()));
+ new ProxyOverriddenBubbleDelegate(browser()->profile()), browser()));
// The second extension is too new to warn about.
EXPECT_FALSE(controller->ShouldShow());

Powered by Google App Engine
This is Rietveld 408576698