chrome/browser/extensions/extension_function_test_utils.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_function_test_utils.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_error_ui_default.h ('k') | chrome/browser/extensions/extension_function_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_function_test_utils.h

diff --git a/chrome/browser/extensions/extension_function_test_utils.h b/chrome/browser/extensions/extension_function_test_utils.h

index f19d506fabd5b9e2eabfe78e03a5af113fd1e4a8..230d739768dd8eaf1cfb78c43e76dccd2c01368f 100644

--- a/chrome/browser/extensions/extension_function_test_utils.h

+++ b/chrome/browser/extensions/extension_function_test_utils.h

@@ -23,7 +23,7 @@ namespace extensions {

class Extension;

}

-// TODO(ckehoe): Accept args as scoped_ptr<base::Value>,

+// TODO(ckehoe): Accept args as std::unique_ptr<base::Value>,

// and migrate existing users to the new API.

// This file is DEPRECATED. New tests should use the versions in

// extensions/browser/api_test_utils.h.

@@ -88,7 +88,7 @@ bool RunFunction(UIThreadExtensionFunction* function,

Browser* browser,

RunFunctionFlags flags);

bool RunFunction(UIThreadExtensionFunction* function,

- scoped_ptr<base::ListValue> args,

+ std::unique_ptr<base::ListValue> args,

Browser* browser,

RunFunctionFlags flags);