chrome/browser/extensions/browser_extension_window_controller.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/browser_action_test_util.h ('k') | chrome/browser/extensions/browser_extension_window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_extension_window_controller.h

diff --git a/chrome/browser/extensions/browser_extension_window_controller.h b/chrome/browser/extensions/browser_extension_window_controller.h

index c69bb9708298bd820cae3e930d7b26afa5b5400d..0106a77a9d9ca4546a90909123b331e3f24e81bb 100644

--- a/chrome/browser/extensions/browser_extension_window_controller.h

+++ b/chrome/browser/extensions/browser_extension_window_controller.h

@@ -27,7 +27,7 @@ class BrowserExtensionWindowController : public extensions::WindowController {

const extensions::Extension* extension) const override;

base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,

int tab_index) const override;

- scoped_ptr<extensions::api::tabs::Tab> CreateTabObject(

+ std::unique_ptr<extensions::api::tabs::Tab> CreateTabObject(

const extensions::Extension* extension,

int tab_index) const override;

bool CanClose(Reason* reason) const override;