chrome/browser/extensions/extension_action_storage_manager.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_storage_manager.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_runner_browsertest.cc ('k') | chrome/browser/extensions/extension_action_storage_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_storage_manager.h

diff --git a/chrome/browser/extensions/extension_action_storage_manager.h b/chrome/browser/extensions/extension_action_storage_manager.h

index de1d63b9e778601ed9df83b3f01d091fb9cd1b84..a11ecf65797eee18513b2876fdf66510531cff79 100644

--- a/chrome/browser/extensions/extension_action_storage_manager.h

+++ b/chrome/browser/extensions/extension_action_storage_manager.h

@@ -44,8 +44,8 @@ class ExtensionActionStorageManager : public ExtensionActionAPI::Observer,

// Reads/Writes the ExtensionAction's default values to/from storage.

void WriteToStorage(ExtensionAction* extension_action);

- void ReadFromStorage(

- const std::string& extension_id, scoped_ptr<base::Value> value);

+ void ReadFromStorage(const std::string& extension_id,

+ std::unique_ptr<base::Value> value);

// Returns the Extensions StateStore for the |browser_context_|.

// May return NULL.