chrome/browser/extensions/error_console/error_console.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/error_console/error_console.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/display_info_provider_chromeos.cc ('k') | chrome/browser/extensions/error_console/error_console.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/error_console/error_console.h

diff --git a/chrome/browser/extensions/error_console/error_console.h b/chrome/browser/extensions/error_console/error_console.h

index df2ad4f2af2ed109e4037c0962a84fb147d2d82c..06974fee9bb5c66c7610f8a75d13a65d846f5c2a 100644

--- a/chrome/browser/extensions/error_console/error_console.h

+++ b/chrome/browser/extensions/error_console/error_console.h

@@ -8,8 +8,9 @@

#include <stddef.h>

#include <stdint.h>

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "base/observer_list.h"

#include "base/scoped_observer.h"

#include "base/threading/thread_checker.h"

@@ -87,7 +88,7 @@ class ErrorConsole : public KeyedService,

void UseDefaultReportingForExtension(const std::string& extension_id);

// Report an extension error, and add it to the list.

- void ReportError(scoped_ptr<ExtensionError> error);

+ void ReportError(std::unique_ptr<ExtensionError> error);

// Removes errors from the map according to the given |filter|.

void RemoveErrors(const ErrorMap::Filter& filter);