chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/settings_private/settings_private_event_router.cc ('k') | chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

diff --git a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h b/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

index a12663384256fed624937316c5f81a327bb11f00..69a8dfabb86ffe9eafb54bf985e38044c8e9d01a 100644

--- a/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

+++ b/chrome/browser/extensions/api/signed_in_devices/id_mapping_helper.h

@@ -5,10 +5,10 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_ID_MAPPING_HELPER_H__

#define CHROME_BROWSER_EXTENSIONS_API_SIGNED_IN_DEVICES_ID_MAPPING_HELPER_H__

+#include <memory>

#include <string>

#include <vector>

-#include "base/memory/scoped_ptr.h"

namespace base {

class DictionaryValue;

@@ -50,7 +50,7 @@ void CreateMappingForUnmappedDevices(

// Gets the device info for a given client id. If the device is not found

// the returned pointer would be null.

-scoped_ptr<sync_driver::DeviceInfo> GetDeviceInfoForClientId(

+std::unique_ptr<sync_driver::DeviceInfo> GetDeviceInfoForClientId(

const std::string& client_id,

const std::string& extension_id,

Profile* profile);