chrome/browser/extensions/extension_install_ui_util.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_install_ui_util.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt_unittest.cc ('k') | chrome/browser/extensions/extension_keybinding_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_install_ui_util.cc

diff --git a/chrome/browser/extensions/extension_install_ui_util.cc b/chrome/browser/extensions/extension_install_ui_util.cc

index 425e704571b605624d1d7f61a10abca290744b1d..fe90f8dd0088b10edcc21634b353e7f3e31132ad 100644

--- a/chrome/browser/extensions/extension_install_ui_util.cc

+++ b/chrome/browser/extensions/extension_install_ui_util.cc

@@ -4,7 +4,8 @@

#include "chrome/browser/extensions/extension_install_ui_util.h"

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "chrome/browser/ui/extensions/extension_install_ui_factory.h"

#include "extensions/browser/install/extension_install_ui.h"

@@ -14,7 +15,7 @@ namespace install_ui {

void ShowPostInstallUIForApproval(content::BrowserContext* context,

const WebstoreInstaller::Approval& approval,

const Extension* extension) {

- scoped_ptr<ExtensionInstallUI> install_ui(

+ std::unique_ptr<ExtensionInstallUI> install_ui(

extensions::CreateExtensionInstallUI(context));

install_ui->SetUseAppInstalledBubble(approval.use_app_installed_bubble);

install_ui->SetSkipPostInstallUI(approval.skip_post_install_ui);