chrome/browser/extensions/api/identity/web_auth_flow.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_signin_flow.h ('k') | chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/web_auth_flow.cc

diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.cc b/chrome/browser/extensions/api/identity/web_auth_flow.cc

index 63367649f125b6d74558804eee6450af20e47e03..d8092c701fc7d1d8d232fdf4467af3d4eb41f78d 100644

--- a/chrome/browser/extensions/api/identity/web_auth_flow.cc

+++ b/chrome/browser/extensions/api/identity/web_auth_flow.cc

@@ -82,7 +82,7 @@ void WebAuthFlow::Start() {

base::Base64Encode(random_bytes, &app_window_key_);

// identityPrivate.onWebFlowRequest(app_window_key, provider_url_, mode_)

- scoped_ptr<base::ListValue> args(new base::ListValue());

+ std::unique_ptr<base::ListValue> args(new base::ListValue());

args->AppendString(app_window_key_);

args->AppendString(provider_url_.spec());

if (mode_ == WebAuthFlow::INTERACTIVE)

@@ -90,7 +90,7 @@ void WebAuthFlow::Start() {

else

args->AppendString("silent");

- scoped_ptr<Event> event(new Event(

+ std::unique_ptr<Event> event(new Event(

events::IDENTITY_PRIVATE_ON_WEB_FLOW_REQUEST,

identity_private::OnWebFlowRequest::kEventName, std::move(args)));

event->restrict_to_browser_context = profile_;