chrome/browser/extensions/api/tabs/app_window_controller.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/app_window_controller.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc ('k') | chrome/browser/extensions/api/tabs/app_window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/app_window_controller.h

diff --git a/chrome/browser/extensions/api/tabs/app_window_controller.h b/chrome/browser/extensions/api/tabs/app_window_controller.h

index 437e1810b0dc6f3e7a57de9414d994803f9ff4ae..78f81839624125d53aa6f04c9cd65a13312d7afc 100644

--- a/chrome/browser/extensions/api/tabs/app_window_controller.h

+++ b/chrome/browser/extensions/api/tabs/app_window_controller.h

@@ -22,7 +22,7 @@ class AppBaseWindow;

class AppWindowController : public WindowController {

public:

AppWindowController(AppWindow* window,

- scoped_ptr<AppBaseWindow> base_window,

+ std::unique_ptr<AppBaseWindow> base_window,

Profile* profile);

~AppWindowController() override;

@@ -33,7 +33,7 @@ class AppWindowController : public WindowController {

const Extension* extension) const override;

base::DictionaryValue* CreateTabValue(const Extension* extension,

int tab_index) const override;

- scoped_ptr<api::tabs::Tab> CreateTabObject(

+ std::unique_ptr<api::tabs::Tab> CreateTabObject(

const extensions::Extension* extension,

int tab_index) const override;

@@ -45,7 +45,7 @@ class AppWindowController : public WindowController {

private:

AppWindow* app_window_; // Owns us.

- scoped_ptr<AppBaseWindow> base_window_;

+ std::unique_ptr<AppBaseWindow> base_window_;

DISALLOW_COPY_AND_ASSIGN(AppWindowController);

};