chrome/browser/extensions/api/passwords_private/passwords_private_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/page_capture/page_capture_api.h ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc b/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

index 8b403346d92cfbc19f7d1df7a41cb2eae96c990e..a74dc022928a4f70b467175aa50101e46fdd0bd9 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_api.cc

@@ -21,9 +21,9 @@ PasswordsPrivateRemoveSavedPasswordFunction::

ExtensionFunction::ResponseAction

PasswordsPrivateRemoveSavedPasswordFunction::Run() {

- scoped_ptr<api::passwords_private::RemoveSavedPassword::Params>

- parameters = api::passwords_private::RemoveSavedPassword::Params::

- Create(*args_);

+ std::unique_ptr<api::passwords_private::RemoveSavedPassword::Params>

+ parameters =

+ api::passwords_private::RemoveSavedPassword::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =

@@ -44,9 +44,10 @@ PasswordsPrivateRemovePasswordExceptionFunction::

ExtensionFunction::ResponseAction

PasswordsPrivateRemovePasswordExceptionFunction::Run() {

- scoped_ptr<api::passwords_private::RemovePasswordException::Params>

- parameters = api::passwords_private::RemovePasswordException::

- Params::Create(*args_);

+ std::unique_ptr<api::passwords_private::RemovePasswordException::Params>

+ parameters =

+ api::passwords_private::RemovePasswordException::Params::Create(

+ *args_);

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =

@@ -65,9 +66,10 @@ PasswordsPrivateRequestPlaintextPasswordFunction::

ExtensionFunction::ResponseAction

PasswordsPrivateRequestPlaintextPasswordFunction::Run() {

- scoped_ptr<api::passwords_private::RequestPlaintextPassword::Params>

- parameters = api::passwords_private::RequestPlaintextPassword::Params::

- Create(*args_);

+ std::unique_ptr<api::passwords_private::RequestPlaintextPassword::Params>

+ parameters =

+ api::passwords_private::RequestPlaintextPassword::Params::Create(

+ *args_);

EXTENSION_FUNCTION_VALIDATE(parameters.get());

PasswordsPrivateDelegate* delegate =