chrome/browser/extensions/api/context_menus/context_menus_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/context_menus/context_menus_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_store_unittest.cc ('k') | chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/context_menus/context_menus_api.cc

diff --git a/chrome/browser/extensions/api/context_menus/context_menus_api.cc b/chrome/browser/extensions/api/context_menus/context_menus_api.cc

index 49abc96ac5ed30ed224f5e22c75ddb2dc6e039ea..90b8849fca2787a6ab0895f62b540d94a1a2ebe8 100644

--- a/chrome/browser/extensions/api/context_menus/context_menus_api.cc

+++ b/chrome/browser/extensions/api/context_menus/context_menus_api.cc

@@ -35,7 +35,7 @@ namespace Update = api::context_menus::Update;

bool ContextMenusCreateFunction::RunSync() {

MenuItem::Id id(GetProfile()->IsOffTheRecord(),

MenuItem::ExtensionKey(extension_id()));

- scoped_ptr<Create::Params> params(Create::Params::Create(*args_));

+ std::unique_ptr<Create::Params> params(Create::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

if (params->create_properties.id.get()) {

@@ -60,7 +60,7 @@ bool ContextMenusCreateFunction::RunSync() {

bool ContextMenusUpdateFunction::RunSync() {

MenuItem::Id item_id(GetProfile()->IsOffTheRecord(),

MenuItem::ExtensionKey(extension_id()));

- scoped_ptr<Update::Params> params(Update::Params::Create(*args_));

+ std::unique_ptr<Update::Params> params(Update::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

if (params->id.as_string)

@@ -75,7 +75,7 @@ bool ContextMenusUpdateFunction::RunSync() {

}

bool ContextMenusRemoveFunction::RunSync() {

- scoped_ptr<Remove::Params> params(Remove::Params::Create(*args_));

+ std::unique_ptr<Remove::Params> params(Remove::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

MenuManager* manager = MenuManager::Get(GetProfile());