chrome/browser/extensions/bundle_installer.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bundle_installer.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/browser_extension_window_controller.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/bundle_installer.h

diff --git a/chrome/browser/extensions/bundle_installer.h b/chrome/browser/extensions/bundle_installer.h

index 9c3888bd81cdb757f3310da0afd7a0fdeabc9165..075c633a0d92a6a6c58fcf0f87ce40dd7c4ddcd6 100644

--- a/chrome/browser/extensions/bundle_installer.h

+++ b/chrome/browser/extensions/bundle_installer.h

@@ -7,13 +7,13 @@

#include <stddef.h>

+#include <memory>

#include <string>

#include <vector>

#include "base/callback_forward.h"

#include "base/macros.h"

#include "base/memory/linked_ptr.h"

-#include "base/memory/scoped_ptr.h"

#include "base/memory/weak_ptr.h"

#include "base/strings/string16.h"

#include "chrome/browser/extensions/extension_install_prompt.h"

@@ -203,7 +203,7 @@ class BundleInstaller : public WebstoreInstallHelper::Delegate,

Profile* profile_;

// The UI that shows the confirmation prompt.

- scoped_ptr<ExtensionInstallPrompt> install_ui_;

+ std::unique_ptr<ExtensionInstallPrompt> install_ui_;

ApprovalCallback approval_callback_;

base::Closure install_callback_;

« no previous file with comments | « chrome/browser/extensions/browser_extension_window_controller.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »