chrome/browser/extensions/extension_action_runner.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_runner.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_manager_unittest.cc ('k') | chrome/browser/extensions/extension_action_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_runner.h

diff --git a/chrome/browser/extensions/extension_action_runner.h b/chrome/browser/extensions/extension_action_runner.h

index d260ee027c1c547f94fe1659064ff462097691d0..16e90970d7232b6051672ad12af429f5c1977f6b 100644

--- a/chrome/browser/extensions/extension_action_runner.h

+++ b/chrome/browser/extensions/extension_action_runner.h

@@ -85,7 +85,7 @@ class ExtensionActionRunner : public content::WebContentsObserver,

int num_page_requests() const { return num_page_requests_; }

void set_default_bubble_close_action_for_testing(

- scoped_ptr<ToolbarActionsBarBubbleDelegate::CloseAction> action) {

+ std::unique_ptr<ToolbarActionsBarBubbleDelegate::CloseAction> action) {

default_bubble_close_action_for_testing_ = std::move(action);

}

@@ -202,7 +202,7 @@ class ExtensionActionRunner : public content::WebContentsObserver,

bool ignore_active_tab_granted_;

// If non-null, the bubble action to simulate for testing.

- scoped_ptr<ToolbarActionsBarBubbleDelegate::CloseAction>

+ std::unique_ptr<ToolbarActionsBarBubbleDelegate::CloseAction>

default_bubble_close_action_for_testing_;

ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>