chrome/browser/extensions/api/socket/socket_apitest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/socket/socket_api_unittest.cc ('k') | chrome/browser/extensions/api/socket/tcp_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/socket_apitest.cc

diff --git a/chrome/browser/extensions/api/socket/socket_apitest.cc b/chrome/browser/extensions/api/socket/socket_apitest.cc

index eb52807312825ca5e164e1cb8b1ccd2b074f94ba..cb2ae769c5d2d7cd4c6d35f514952fb1a6c2e11f 100644

--- a/chrome/browser/extensions/api/socket/socket_apitest.cc

+++ b/chrome/browser/extensions/api/socket/socket_apitest.cc

@@ -55,7 +55,7 @@ class SocketApiTest : public ExtensionApiTest {

} // namespace

IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketUDPExtension) {

- scoped_ptr<net::SpawnedTestServer> test_server(

+ std::unique_ptr<net::SpawnedTestServer> test_server(

new net::SpawnedTestServer(

net::SpawnedTestServer::TYPE_UDP_ECHO,

net::SpawnedTestServer::kLocalhost,

@@ -83,7 +83,7 @@ IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketUDPExtension) {

}

IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPExtension) {

- scoped_ptr<net::SpawnedTestServer> test_server(

+ std::unique_ptr<net::SpawnedTestServer> test_server(

new net::SpawnedTestServer(

net::SpawnedTestServer::TYPE_TCP_ECHO,

net::SpawnedTestServer::kLocalhost,