chrome/browser/extensions/api/browser/browser_api.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/browser/browser_api.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/braille_display_private/stub_braille_controller.cc ('k') | chrome/browser/extensions/api/browser/browser_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/browser/browser_api.cc

diff --git a/chrome/browser/extensions/api/browser/browser_api.cc b/chrome/browser/extensions/api/browser/browser_api.cc

index 7e1a64bd9c38af3eb98acd18d5a17a964909eec8..78bd303fefe2e812d7d8694cfca83136ff72a4c9 100644

--- a/chrome/browser/extensions/api/browser/browser_api.cc

+++ b/chrome/browser/extensions/api/browser/browser_api.cc

@@ -13,7 +13,7 @@ BrowserOpenTabFunction::~BrowserOpenTabFunction() {

}

bool BrowserOpenTabFunction::RunSync() {

- scoped_ptr<browser::OpenTab::Params> params(

+ std::unique_ptr<browser::OpenTab::Params> params(

browser::OpenTab::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

@@ -22,7 +22,7 @@ bool BrowserOpenTabFunction::RunSync() {

options.url.reset(new std::string(params->options.url));

std::string error;

- scoped_ptr<base::DictionaryValue> result(

+ std::unique_ptr<base::DictionaryValue> result(

ExtensionTabUtil::OpenTab(this, options, &error));

if (!result) {

SetError(error);