chrome/browser/extensions/api/declarative_content/content_predicate.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/content_predicate.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_content/content_condition_unittest.cc ('k') | chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/content_predicate.h

diff --git a/chrome/browser/extensions/api/declarative_content/content_predicate.h b/chrome/browser/extensions/api/declarative_content/content_predicate.h

index 0f1c8172fa11a7e787f117f556846f595eced9ec..1237ddf65e787bba2c4cad8e160b1a502fc2e3bc 100644

--- a/chrome/browser/extensions/api/declarative_content/content_predicate.h

+++ b/chrome/browser/extensions/api/declarative_content/content_predicate.h

@@ -5,10 +5,10 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_PREDICATE_H_

#define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_PREDICATE_H_

+#include <memory>

#include <string>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

namespace base {

class Value;

@@ -59,7 +59,7 @@ class ContentPredicateFactory {

// Creates a new predicate from |value|, as specified in the declarative

// API. Sets *|error| and returns null if creation failed for any reason.

- virtual scoped_ptr<const ContentPredicate> CreatePredicate(

+ virtual std::unique_ptr<const ContentPredicate> CreatePredicate(

const Extension* extension,

const base::Value& value,

std::string* error) = 0;