chrome/browser/extensions/api/sessions/session_id.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/session_id.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc ('k') | chrome/browser/extensions/api/sessions/session_id.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/session_id.h

diff --git a/chrome/browser/extensions/api/sessions/session_id.h b/chrome/browser/extensions/api/sessions/session_id.h

index c973f9f443fdd257c446d559c0a95b72bf21204e..627542c6c292558c73bee766a01fcfd53c0b5e9a 100644

--- a/chrome/browser/extensions/api/sessions/session_id.h

+++ b/chrome/browser/extensions/api/sessions/session_id.h

@@ -5,10 +5,10 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_SESSIONS_SESSION_ID_H__

#define CHROME_BROWSER_EXTENSIONS_API_SESSIONS_SESSION_ID_H__

+#include <memory>

#include <string>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

namespace extensions {

@@ -17,7 +17,7 @@ class SessionId {

// Returns a SessionId, representing either a local or a foreign session.

// In the case that the session is local, |session_tag_| will be empty string.

// |session_string| should be in the format that ToString() would produce.

- static scoped_ptr<SessionId> Parse(const std::string& session_string);

+ static std::unique_ptr<SessionId> Parse(const std::string& session_string);

// Constructs a SessionId object for the given session information.

// |session_tag| is the string used to uniquely identify a synced foreign