chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/image_writer_private/operation_unittest.cc ('k') | chrome/browser/extensions/api/image_writer_private/test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc

index 0ed37310304ade1bea7abe1ca669528e1abf9a88..86038b3c6e1781a0b48610a29b07d486b760ff08 100644

--- a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc

+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc

@@ -35,7 +35,7 @@ bool AddDeviceInfo(HANDLE interface_enumerator,

return false;

}

- scoped_ptr<char[]> interface_detail_data_buffer(

+ std::unique_ptr<char[]> interface_detail_data_buffer(

new char[interface_detail_data_size]);

SP_DEVICE_INTERFACE_DETAIL_DATA* interface_detail_data =

@@ -101,7 +101,7 @@ bool AddDeviceInfo(HANDLE interface_enumerator,

query.PropertyId = StorageDeviceProperty;

query.QueryType = PropertyStandardQuery;

- scoped_ptr<char[]> output_buf(new char[1024]);

+ std::unique_ptr<char[]> output_buf(new char[1024]);

status = DeviceIoControl(

device_handle.Get(), // Device handle.

IOCTL_STORAGE_QUERY_PROPERTY, // Flag to request device properties.