chrome/browser/extensions/api/preference/preference_helpers.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_helpers.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_apitest.cc ('k') | chrome/browser/extensions/api/processes/processes_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_helpers.cc

diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc

index c018fa23c9cc36d8e89ccf0adb10db379fc1d6e3..e2b3577cbe59298be11c837761513941770bfb5f 100644

--- a/chrome/browser/extensions/api/preference/preference_helpers.cc

+++ b/chrome/browser/extensions/api/preference/preference_helpers.cc

@@ -127,8 +127,8 @@ void DispatchEventToExtensions(Profile* profile,

}

- scoped_ptr<base::ListValue> args_copy(args->DeepCopy());

- scoped_ptr<Event> event(

+ std::unique_ptr<base::ListValue> args_copy(args->DeepCopy());

+ std::unique_ptr<Event> event(

new Event(histogram_value, event_name, std::move(args_copy)));

event->restrict_to_browser_context = restrict_to_profile;

router->DispatchEventToExtension(extension->id(), std::move(event));