chrome/browser/extensions/convert_web_app.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/convert_web_app.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/convert_web_app.cc

diff --git a/chrome/browser/extensions/convert_web_app.cc b/chrome/browser/extensions/convert_web_app.cc

index e920b455fa60f360627a2cb0038495aff3049ed7..409eb9baaff391adfed6eff2e3ef6c21ba77cc33 100644

--- a/chrome/browser/extensions/convert_web_app.cc

+++ b/chrome/browser/extensions/convert_web_app.cc

@@ -102,7 +102,7 @@ scoped_refptr<Extension> ConvertWebAppToExtension(

}

// Create the manifest

- scoped_ptr<base::DictionaryValue> root(new base::DictionaryValue);

+ std::unique_ptr<base::DictionaryValue> root(new base::DictionaryValue);

root->SetString(keys::kPublicKey, GenerateKey(web_app.app_url));

root->SetString(keys::kName, base::UTF16ToUTF8(web_app.title));

root->SetString(keys::kVersion, ConvertTimeToExtensionVersion(create_time));

« no previous file with comments | « chrome/browser/extensions/convert_user_script_unittest.cc ('k') | chrome/browser/extensions/crx_installer.h » ('j') | no next file with comments »