chrome/browser/extensions/api/notifications/notifications_apitest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_api.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/notifications/notifications_apitest.cc

diff --git a/chrome/browser/extensions/api/notifications/notifications_apitest.cc b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

index ee6eef5506972d1d4982ddd6d37be1f9860f0bc2..426eea9aa2ed4f1af50186fc70c0f2c2ba1fa3a4 100644

--- a/chrome/browser/extensions/api/notifications/notifications_apitest.cc

+++ b/chrome/browser/extensions/api/notifications/notifications_apitest.cc

@@ -196,11 +196,8 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestGetPermissionLevel) {

notification_function->set_extension(empty_extension.get());

notification_function->set_has_callback(true);

- scoped_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(

- notification_function.get(),

- "[]",

- browser(),

- utils::NONE));

+ std::unique_ptr<base::Value> result(utils::RunFunctionAndReturnSingleResult(

+ notification_function.get(), "[]", browser(), utils::NONE));

EXPECT_EQ(base::Value::TYPE_STRING, result->GetType());

std::string permission_level;

@@ -224,11 +221,8 @@ IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestGetPermissionLevel) {

g_browser_process->message_center()->GetNotifierSettingsProvider()->

SetNotifierEnabled(notifier, false);