chrome/browser/extensions/extension_app_icon_loader.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_app_icon_loader.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_app_icon_loader.h ('k') | chrome/browser/extensions/extension_assets_manager_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_app_icon_loader.cc

diff --git a/chrome/browser/extensions/extension_app_icon_loader.cc b/chrome/browser/extensions/extension_app_icon_loader.cc

index 992568e5e10666c0ba86f30c0769f630b13bd63b..4d292ba6715d5ea9f404b884c98c11e7780757c1 100644

--- a/chrome/browser/extensions/extension_app_icon_loader.cc

+++ b/chrome/browser/extensions/extension_app_icon_loader.cc

@@ -54,13 +54,9 @@ void ExtensionAppIconLoader::FetchImage(const std::string& id) {

if (!extension)

return;

- scoped_ptr<extensions::IconImage> image(new extensions::IconImage(

- profile(),

- extension,

- extensions::IconsInfo::GetIcons(extension),

- icon_size(),

- extensions::util::GetDefaultAppIcon(),

- this));

+ std::unique_ptr<extensions::IconImage> image(new extensions::IconImage(

+ profile(), extension, extensions::IconsInfo::GetIcons(extension),

+ icon_size(), extensions::util::GetDefaultAppIcon(), this));

// Triggers image loading now instead of depending on paint message. This

// makes the temp blank image be shown for shorter time and improves user