chrome/browser/extensions/chrome_app_api_browsertest.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_app_api_browsertest.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/bundle_installer.cc ('k') | chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/chrome_app_api_browsertest.cc

diff --git a/chrome/browser/extensions/chrome_app_api_browsertest.cc b/chrome/browser/extensions/chrome_app_api_browsertest.cc

index 108d57b5f3cd5cfed0056d57206db24ff2e8477c..8bbc52e43986bdab2dfee9060248ed268d9efb91 100644

--- a/chrome/browser/extensions/chrome_app_api_browsertest.cc

+++ b/chrome/browser/extensions/chrome_app_api_browsertest.cc

@@ -2,11 +2,11 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <memory>

#include <string>

#include "base/command_line.h"

#include "base/json/json_reader.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/string_number_conversions.h"

#include "base/values.h"

#include "chrome/browser/extensions/extension_browsertest.h"

@@ -137,7 +137,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) {

browser()->tab_strip_model()->GetActiveWebContents(),

kGetAppDetails,

&result));

- scoped_ptr<base::DictionaryValue> app_details(

+ std::unique_ptr<base::DictionaryValue> app_details(

static_cast<base::DictionaryValue*>(

base::JSONReader::Read(result).release()));

// extension->manifest() does not contain the id.