chrome/browser/extensions/extension_action_runner.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_action_runner.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_action_runner.h ('k') | chrome/browser/extensions/extension_action_runner_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_action_runner.cc

diff --git a/chrome/browser/extensions/extension_action_runner.cc b/chrome/browser/extensions/extension_action_runner.cc

index 8be229b23a0f90e11e31e083390426429b0f9d80..a9036104ec92a4c39e5c3cea2b5155c965bec60b 100644

--- a/chrome/browser/extensions/extension_action_runner.cc

+++ b/chrome/browser/extensions/extension_action_runner.cc

@@ -4,10 +4,12 @@

#include "chrome/browser/extensions/extension_action_runner.h"

+#include <memory>

#include "base/auto_reset.h"

#include "base/bind.h"

#include "base/bind_helpers.h"

-#include "base/memory/scoped_ptr.h"

+#include "base/memory/ptr_util.h"

#include "base/metrics/histogram.h"

#include "base/stl_util.h"

#include "chrome/browser/extensions/active_tab_permission_granter.h"

@@ -352,7 +354,7 @@ void ExtensionActionRunner::ShowBlockedActionBubble(

FROM_HERE,

base::Bind(callback, *default_bubble_close_action_for_testing_));

} else {

- toolbar_actions_bar->ShowToolbarActionBubble(make_scoped_ptr(

+ toolbar_actions_bar->ShowToolbarActionBubble(base::WrapUnique(

new BlockedActionBubbleDelegate(callback, extension->id())));

}