chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/log_private/log_private_api_chromeos.cc ('k') | chrome/browser/extensions/api/management/chrome_management_api_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

diff --git a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

index bddbdab7e509e915cdc140077ef1dc4d37a35b1a..1cb54030adea11edc09ba69867213c59b5cac761 100644

--- a/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

+++ b/chrome/browser/extensions/api/log_private/log_private_apitest_chromeos.cc

@@ -72,13 +72,13 @@ class LogPrivateApiTest : public ExtensionApiTest {

base::FilePath tar_file_path =

test_data_dir_.Append("log_private/dump_logs/system_logs.tar");

chromeos::DBusThreadManager::GetSetterForTesting()->SetDebugDaemonClient(

- scoped_ptr<chromeos::DebugDaemonClient>(

+ std::unique_ptr<chromeos::DebugDaemonClient>(

new TestDebugDaemonClient(tar_file_path)));

ExtensionApiTest::SetUpInProcessBrowserTestFixture();

}

- scoped_ptr<HttpResponse> HandleRequest(const HttpRequest& request) {

- scoped_ptr<BasicHttpResponse> response(new BasicHttpResponse);

+ std::unique_ptr<HttpResponse> HandleRequest(const HttpRequest& request) {

+ std::unique_ptr<BasicHttpResponse> response(new BasicHttpResponse);

response->set_code(net::HTTP_OK);

response->set_content(

"<html><head><title>LogPrivateTest</title>"