chrome/browser/extensions/activity_log/counting_policy.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/counting_policy.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_unittest.cc ('k') | chrome/browser/extensions/activity_log/counting_policy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/counting_policy.h

diff --git a/chrome/browser/extensions/activity_log/counting_policy.h b/chrome/browser/extensions/activity_log/counting_policy.h

index 26b090a59419ea4f0b66f40162878dbbd80d62df..33f24ece4f212bdb9def531f7c0c228d02abdb3c 100644

--- a/chrome/browser/extensions/activity_log/counting_policy.h

+++ b/chrome/browser/extensions/activity_log/counting_policy.h

@@ -37,8 +37,8 @@ class CountingPolicy : public ActivityLogDatabasePolicy {

const std::string& page_url,

const std::string& arg_url,

const int days_ago,

- const base::Callback<void(scoped_ptr<Action::ActionVector>)>& callback)

- override;

+ const base::Callback<void(std::unique_ptr<Action::ActionVector>)>&

+ callback) override;

void Close() override;

@@ -89,7 +89,7 @@ class CountingPolicy : public ActivityLogDatabasePolicy {

// Internal method to read data from the database; called on the database

// thread.

- scoped_ptr<Action::ActionVector> DoReadFilteredData(

+ std::unique_ptr<Action::ActionVector> DoReadFilteredData(

const std::string& extension_id,

const Action::ActionType type,

const std::string& api_name,