chrome/browser/extensions/window_controller.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/window_controller.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/window_controller.h

diff --git a/chrome/browser/extensions/window_controller.h b/chrome/browser/extensions/window_controller.h

index 5bd45cbaa7f2ff146978ace3cc46cd4b36665bbd..c54a98b4ce87313fa23f5d93feee83b73bd5eeac 100644

--- a/chrome/browser/extensions/window_controller.h

+++ b/chrome/browser/extensions/window_controller.h

@@ -85,11 +85,11 @@ class WindowController {

virtual base::DictionaryValue* CreateWindowValueWithTabs(

const extensions::Extension* extension) const = 0;

- virtual scoped_ptr<api::tabs::Tab> CreateTabObject(

+ virtual std::unique_ptr<api::tabs::Tab> CreateTabObject(

const extensions::Extension* extension,

int tab_index) const = 0;

- // DEPRECATED: Use scoped_ptr<api::tabs::Tab> CreateTabObject(...)

+ // DEPRECATED: Use std::unique_ptr<api::tabs::Tab> CreateTabObject(...)

virtual base::DictionaryValue* CreateTabValue(

const extensions::Extension* extension, int tab_index) const = 0;

« no previous file with comments | « chrome/browser/extensions/webstore_startup_installer.cc ('k') | chrome/browser/extensions/zipfile_installer.h » ('j') | no next file with comments »