chrome/browser/extensions/api/tabs/tabs_windows_api.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_windows_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/tabs/tabs_windows_api.h

diff --git a/chrome/browser/extensions/api/tabs/tabs_windows_api.h b/chrome/browser/extensions/api/tabs/tabs_windows_api.h

index 4fe76e8ca72e7da6f34efd6bf2c22f1761835781..78b4a421eb7bdf20122f2b30074e0f6bae9281ce 100644

--- a/chrome/browser/extensions/api/tabs/tabs_windows_api.h

+++ b/chrome/browser/extensions/api/tabs/tabs_windows_api.h

@@ -5,7 +5,8 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_WINDOWS_API_H_

#define CHROME_BROWSER_EXTENSIONS_API_TABS_TABS_WINDOWS_API_H_

-#include "base/memory/scoped_ptr.h"

+#include <memory>

#include "components/keyed_service/core/keyed_service.h"

#include "extensions/browser/browser_context_keyed_api_factory.h"

#include "extensions/browser/event_router.h"

@@ -46,8 +47,8 @@ class TabsWindowsAPI : public BrowserContextKeyedAPI,

}

static const bool kServiceIsNULLWhileTesting = true;

- scoped_ptr<TabsEventRouter> tabs_event_router_;

- scoped_ptr<WindowsEventRouter> windows_event_router_;

+ std::unique_ptr<TabsEventRouter> tabs_event_router_;

+ std::unique_ptr<WindowsEventRouter> windows_event_router_;

};

} // namespace extensions

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_test.cc ('k') | chrome/browser/extensions/api/tabs/windows_event_router.h » ('j') | no next file with comments »