chrome/browser/extensions/api/messaging/native_process_launcher_win.cc - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher.cc ('k') | chrome/browser/extensions/api/metrics_private/metrics_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

index be44395800ed745404d251aaeb3785121bcf26a1..1d51922fd275306dc4251b7057bd5e49a93a16aa 100644

--- a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

+++ b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

@@ -140,7 +140,7 @@ bool NativeProcessLauncher::LaunchNativeProcess(

LOG(ERROR) << "COMSPEC is not set";

return false;

}

- scoped_ptr<wchar_t[]> comspec(new wchar_t[comspec_length]);

+ std::unique_ptr<wchar_t[]> comspec(new wchar_t[comspec_length]);

::GetEnvironmentVariable(L"COMSPEC", comspec.get(), comspec_length);

base::string16 command_line_string = command_line.GetCommandLineString();