chrome/browser/extensions/api/webstore_widget_private/app_installer.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_widget_private/app_installer.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webstore_private/webstore_private_apitest.cc ('k') | chrome/browser/extensions/api/webstore_widget_private/app_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_widget_private/app_installer.h

diff --git a/chrome/browser/extensions/api/webstore_widget_private/app_installer.h b/chrome/browser/extensions/api/webstore_widget_private/app_installer.h

index 8df3bf8ea6561443eeaf12533f9e8837b3e9f4a1..b142bf73ff67fadadd83fd19b5f610fd86fb8afb 100644

--- a/chrome/browser/extensions/api/webstore_widget_private/app_installer.h

+++ b/chrome/browser/extensions/api/webstore_widget_private/app_installer.h

@@ -41,7 +41,7 @@ class AppInstaller : public extensions::WebstoreStandaloneInstaller {

bool ShouldShowPostInstallUI() const override;

bool ShouldShowAppInstalledBubble() const override;

content::WebContents* GetWebContents() const override;

- scoped_ptr<ExtensionInstallPrompt::Prompt> CreateInstallPrompt()

+ std::unique_ptr<ExtensionInstallPrompt::Prompt> CreateInstallPrompt()

const override;

bool CheckInlineInstallPermitted(const base::DictionaryValue& webstore_data,

std::string* error) const override;

@@ -54,7 +54,7 @@ class AppInstaller : public extensions::WebstoreStandaloneInstaller {

bool silent_installation_;

Callback callback_;

content::WebContents* web_contents_;

- scoped_ptr<WebContentsObserver> web_contents_observer_;

+ std::unique_ptr<WebContentsObserver> web_contents_observer_;

DISALLOW_IMPLICIT_CONSTRUCTORS(AppInstaller);

};