chrome/browser/extensions/api/history/history_api.h - Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/history/history_api.h

Issue 1871713002: Convert //chrome/browser/extensions from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fix header Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/history/history_api.h

diff --git a/chrome/browser/extensions/api/history/history_api.h b/chrome/browser/extensions/api/history/history_api.h

index 55c48faa7773dc243483d0d26b2b6cf127c0d95a..bfbb014049e802dc750f75907971f36cc989c6d0 100644

--- a/chrome/browser/extensions/api/history/history_api.h

+++ b/chrome/browser/extensions/api/history/history_api.h

@@ -52,7 +52,7 @@ class HistoryEventRouter : public history::HistoryServiceObserver {

void DispatchEvent(Profile* profile,

events::HistogramValue histogram_value,

const std::string& event_name,

- scoped_ptr<base::ListValue> event_args);

+ std::unique_ptr<base::ListValue> event_args);

Profile* profile_;

ScopedObserver<history::HistoryService, history::HistoryServiceObserver>

@@ -87,7 +87,7 @@ class HistoryAPI : public BrowserContextKeyedAPI, public EventRouter::Observer {

static const bool kServiceIsNULLWhileTesting = true;

// Created lazily upon OnListenerAdded.

- scoped_ptr<HistoryEventRouter> history_event_router_;

+ std::unique_ptr<HistoryEventRouter> history_event_router_;

};

template <>

« no previous file with comments | « chrome/browser/extensions/api/gcm/gcm_api.cc ('k') | chrome/browser/extensions/api/history/history_api.cc » ('j') | no next file with comments »